mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50138: Synced up common/values.cpp and v1/values.cpp.
Date Mon, 18 Jul 2016 19:39:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50138/#review142615
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50138]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 18, 2016, 2:57 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50138/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 2:57 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix synced up two patches from common/values.cpp to
> v1/values.cpp.
> 
> 1) https://reviews.apache.org/r/45813/ Removed capture by
>    reference.
> 2) https://reviews.apache.org/r/48593/ Refactor Value::Ranges
>    subtraction.
> 
> 
> Diffs
> -----
> 
>   src/v1/values.cpp 3e0f739b69e680f9eb29ed36d4501c393758c861 
> 
> Diff: https://reviews.apache.org/r/50138/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message