mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49844: Fixed a subscriber FD leak when running tests.
Date Sun, 17 Jul 2016 21:15:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49844/
-----------------------------------------------------------

(Updated July 17, 2016, 9:15 p.m.)


Review request for mesos, Vinod Kone and Zhitao Li.


Changes
-------

Added a comment around making `HttpConnection` a RAII class. NNFR


Bugs: MESOS-5812
    https://issues.apache.org/jira/browse/MESOS-5812


Repository: mesos


Description (updated)
-------

This FD leak would only surface when running tests. We hold on to
a reference of the `Connection` object in the client so that it is
not destroyed while the connection is active. When running tests,
the IP:Port of libprocess remain the same which means the objects
keep on accumulating. In a real world cluster, we remove the
subscriber upon noticing a _disconnection_ i.e. this means the
socket has already been already closed upstream by Libprocess on
the server side.


Diffs (updated)
-----

  src/master/master.hpp ac998b1f5b305a9bff9d9e5cd205a6c3481f9b38 
  src/master/master.cpp 79e3d78ba45060bc2f2532fdc3d105d1cc888d0f 

Diff: https://reviews.apache.org/r/49844/diff/


Testing
-------

make check (gtest_repeat=1000) no FD leaks


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message