mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 50107: Handled /etc/* file being dead links in CNI isolator.
Date Sun, 17 Jul 2016 00:29:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50107/#review142504
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1569)
<https://reviews.apache.org/r/50107/#comment208053>

    Maybe we should add the following code here to create the parent dir of the mount point?
    ```
    // Create the parent directory of the mount point.
    Try<Nothing> mkdir = os::mkdir(Path(target).dirname());
    if (mkdir.isError()) {
      cerr << "Failed to create directory '" << Path(target).dirname()
      << "': " << mkdir.error() << endl;
    }
    ```


- Qian Zhang


On July 17, 2016, 1:13 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50107/
> -----------------------------------------------------------
> 
> (Updated July 17, 2016, 1:13 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Bugs: MESOS-5806
>     https://issues.apache.org/jira/browse/MESOS-5806
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Handled /etc/* file being dead links in CNI isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 11b826e177cf4db6b80027fd221e84ab85c4efbc

> 
> Diff: https://reviews.apache.org/r/50107/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message