mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tuan-Anh Hoang-Vu <hvtuan...@gmail.com>
Subject Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.
Date Sat, 16 Jul 2016 16:34:43 GMT


> On July 16, 2016, 4:11 a.m., Abhishek Dasgupta wrote:
> > src/master/http.cpp, line 1947
> > <https://reviews.apache.org/r/49938/diff/4/?file=1444999#file1444999line1947>
> >
> >     We can't put UNREACHABLE() here.May be we have to write here:
> >     return Failure("Some Message");
> >     
> >     Anyway, check it with your shepherd what you need to put here.

I see. Now I got it. UNREACHABLE() is to handle the `default` case, but we need to handle
the `UNKNOWN` case differently.


- Tuan-Anh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49938/#review142482
-----------------------------------------------------------


On July 15, 2016, 11:13 a.m., Tuan-Anh Hoang-Vu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49938/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 11:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-5731
>     https://issues.apache.org/jira/browse/MESOS-5731
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated Master::GET_METRICS call to return metrics grouped by types.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 7fb7153b5498a55469d2c72873c45fb534c0e60d 
>   include/mesos/v1/master/master.proto c9e4359fff018de55d83da5cde0eb6d59dacfc3e 
>   src/master/http.cpp 42ba3643daf8f6fe63152178214b57e3b773d93e 
>   src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 
> 
> Diff: https://reviews.apache.org/r/49938/diff/
> 
> 
> Testing
> -------
> 
> Modified MasterAPITest.GetMetrics to make sure we return metrics grouped by types.
> 
> 
> 1. Run master: ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> 2. Call GET_METRICS: curl --header "Content-Type:application/json" --data '{"type": "GET_METRICS",
"get_metrics":{}}' http://localhost:5050/api/v1 | python -m json.tool
> 
> 
> Thanks,
> 
> Tuan-Anh Hoang-Vu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message