mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.
Date Sat, 16 Jul 2016 03:36:26 GMT


> On July 12, 2016, 2:24 a.m., Jay Guo wrote:
> > src/tests/mesos.hpp, line 582
> > <https://reviews.apache.org/r/49913/diff/1/?file=1441528#file1441528line582>
> >
> >     why `role1` but not `role`?
> 
> Abhishek Dasgupta wrote:
>     There are three reasons for this:
>     
>     1. Renaming to role instead of role1 needs more changes in the codebases.
>     2. In persistant_volume tests, it is testing against JSON for "role : role1", here
it looks a little qeer if used "role : role".
>     3. In future, if we need to add more roles, it would be rational to add as "role2",
"role3" .. So, this one is named as role1.
>     
>     What do you think?

Reasonable, I'll drop the issue. :)


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49913/#review141832
-----------------------------------------------------------


On July 15, 2016, 11:08 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49913/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 11:08 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5725
>     https://issues.apache.org/jira/browse/MESOS-5725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There were multiple createFrameworkInfo() definition scattered
> in various testcases. In this patch, only one defintion of
> createFrameworkInfo() is provided in src/tests/mesos.hpp and
> other tests just used this definition.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp b4a6c46cd3e0e57b4f4d22d2103d3947c592e133 
>   src/tests/mesos.hpp e4eccfc3810bed3649a3ab80e252849470de4c72 
>   src/tests/persistent_volume_endpoints_tests.cpp 2a22f3b0da817e650a25e5e2c951adb7462718b4

>   src/tests/reservation_endpoints_tests.cpp 48c002d1dc371c285b9421ef5a2c57250d270fa8

> 
> Diff: https://reviews.apache.org/r/49913/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message