mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.
Date Sat, 16 Jul 2016 00:25:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50003/#review142468
-----------------------------------------------------------



Bad patch!

Reviews applied: [50003, 50002]

Failed command: ./support/apply-review.sh -n -r 50003

Error:
2016-07-16 00:25:35 URL:https://reviews.apache.org/r/50003/diff/raw/ [4380/4380] -> "50003.patch"
[1]
error: patch failed: src/tests/test_framework_test.sh:20
error: src/tests/test_framework_test.sh: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14335/console

- Mesos ReviewBot


On July 15, 2016, 9:01 p.m., Ammar Askar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50003/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5613
>     https://issues.apache.org/jira/browse/MESOS-5613
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Propagate work_dir flag from local runs to agents/masters.
> 
> 
> Diffs
> -----
> 
>   src/local/flags.hpp f0af0d2 
>   src/local/local.cpp a543aef 
>   src/tests/test_framework_test.sh 617ca52 
> 
> Diff: https://reviews.apache.org/r/50003/diff/
> 
> 
> Testing
> -------
> 
> Manually tested that `mesos local` and `mesos-local` run now. Not sure if a regression
test for this would be good, please advise.
> 
> 
> Thanks,
> 
> Ammar Askar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message