mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 49990: Added cmake scripts to build slave component libraries.
Date Fri, 15 Jul 2016 20:10:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49990/#review142436
-----------------------------------------------------------


Ship it!




LGTM!

Verified the build on OSX and Windows.

- Joseph Wu


On July 13, 2016, 7:32 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49990/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 7:32 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added cmake scripts to build slave component libraries.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt d31440cb5e784d3e4f1236ac45001e80384f36f6 
>   src/slave/cmake/SlaveConfigure.cmake ca4575653e00e8f868160976344ac1d57b5f7d27 
>   src/slave/qos_controllers/CMakeLists.txt PRE-CREATION 
>   src/slave/resource_estimators/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49990/diff/
> 
> 
> Testing
> -------
> 
> cmake .. && make (builds the dynamic libraries)
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message