mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.
Date Fri, 15 Jul 2016 17:49:50 GMT


> On July 15, 2016, 3:35 p.m., Jiang Yan Xu wrote:
> > Modulo Gaungya's comments.
> 
> Jiang Yan Xu wrote:
>     In the testing done section: 72 us reduction from how much time originally? :)

The timing was from a no-op sort. Took 155us for 1000 clients with a list, 83us or so with
a vector. I didn't really want to go into much detail since I just wanted to show that this
doesn't make things worse, because this code dates from before we switched to prefer vector
over list.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50044/#review142383
-----------------------------------------------------------


On July 14, 2016, 7:35 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50044/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 7:35 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We now prefer to use vector rather than list in general for
> efficiency reasons, unless we need to take advantage of the
> operations that are efficient on a linked-list.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/drf/sorter.hpp e29feebd70277c79f7c3f6fb233e7a36501cf220

>   src/master/allocator/sorter/drf/sorter.cpp 7df4dd641b21ea0705368861bf4679fed1ef078d

>   src/master/allocator/sorter/sorter.hpp f5f0b086cb95eb2ab70b3f67e5b20814925bf702 
>   src/tests/sorter_tests.cpp bdd4355bfcd7b1fa1c22983f8e0ee6f20906917a 
> 
> Diff: https://reviews.apache.org/r/50044/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> benchmarks: with 1000 clients, sort time is reduced by 72 us
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message