mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.
Date Fri, 15 Jul 2016 15:35:33 GMT


> On July 13, 2016, 10:09 a.m., Neil Conway wrote:
> > src/tests/api_tests.cpp, line 95
> > <https://reviews.apache.org/r/49914/diff/1/?file=1441531#file1441531line95>
> >
> >     Rather than changing this for all tests implicitly, I'd prefer creating a `master::Flags`
and changing the allocation interval explicitly in the tests that benefit from it.
> 
> Abhishek Dasgupta wrote:
>     Ok.. I was working over this. Do you mean to say to write a createMasterFlags() in
tests/mesos.hpp as inline function and use that instead of current virtual function? It needs
a long streak of small changes in many of the current tests.

Posted https://reviews.apache.org/r/50072/

Is it that what you asked for?


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49914/#review142046
-----------------------------------------------------------


On July 15, 2016, 3:33 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49914/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 3:33 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5732
>     https://issues.apache.org/jira/browse/MESOS-5732
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In this patch, speed of  'MasterAPITest.UnreserveResources'
> is increased by removing the unnecessary check for unreserved
> resources which is already verified in
> 'MasterAPITest.ReserveResources' and thus by removing the
> delay for waiting for the resource offers to be declined.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp b4a6c46cd3e0e57b4f4d22d2103d3947c592e133 
> 
> Diff: https://reviews.apache.org/r/49914/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message