mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 50078: Cleaned the arguments passed to health checker in docker executor.
Date Fri, 15 Jul 2016 14:13:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50078/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Till Toenshoff.


Bugs: MESOS-5848
    https://issues.apache.org/jira/browse/MESOS-5848


Repository: mesos


Description
-------

Docker executor wraps the health check command into `docker exec`
and leverages mesos-health-check binary to actually perform the
check. However prior to this patch there were unnecessary arguments
passed to the binary, including `path` / `argv[0]` mismatch, log
message was misleading as well.


Diffs
-----

  src/docker/executor.cpp 69511044e39bc05d7d6240264ec70b6e6f44edba 

Diff: https://reviews.apache.org/r/50078/diff/


Testing
-------

make check


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message