mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 50060: Always call watch.stop() to get an accurate time for benchmark test.
Date Fri, 15 Jul 2016 04:04:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50060/#review142329
-----------------------------------------------------------



Patch looks great!

Reviews applied: [49943, 49781, 50060]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 15, 2016, 2:27 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50060/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 2:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Klaus Ma, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This path include two fixes:
> 1) Always call watch.stop() explicitly to get an accurate time
> for benchmark test.
> 2) Move `watch.start()` right before `allocator->addSlave` to
> make the time more accurate.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 153c9b4cf4819e976910c5a7ad9602028e2d22eb

> 
> Diff: https://reviews.apache.org/r/50060/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --benchmark --gtest_filter="*HierarchicalAllocator_BENCHMARK_Test.*/1"
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message