mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Review Request 50060: Always call watch.stop() to get an accurate time for benchmark test.
Date Fri, 15 Jul 2016 02:27:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50060/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Klaus Ma, and Jiang Yan Xu.


Repository: mesos


Description
-------

This path include two fixes:
1) Always call watch.stop() explicitly to get an accurate time
for benchmark test.
2) Move `watch.start()` right before `allocator->addSlave` to
make the time more accurate.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp 153c9b4cf4819e976910c5a7ad9602028e2d22eb 

Diff: https://reviews.apache.org/r/50060/diff/


Testing
-------

./bin/mesos-tests.sh --benchmark --gtest_filter="*HierarchicalAllocator_BENCHMARK_Test.*/1"


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message