mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tuan-Anh Hoang-Vu <hvtuan...@gmail.com>
Subject Re: Review Request 49939: Updated Agent::GET_METRICS call to return metrics grouped by types.
Date Thu, 14 Jul 2016 21:32:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49939/
-----------------------------------------------------------

(Updated July 14, 2016, 2:32 p.m.)


Review request for mesos, Benjamin Mahler and Vinod Kone.


Summary (updated)
-----------------

Updated Agent::GET_METRICS call to return metrics grouped by types.


Bugs: MESOS-5731
    https://issues.apache.org/jira/browse/MESOS-5731


Repository: mesos


Description (updated)
-------

Updated Agent::GET_METRICS call to return metrics grouped by types.


Diffs (updated)
-----

  include/mesos/agent/agent.proto cfd117de81396bf79049b7642f1ccd1ff4fbb676 
  include/mesos/v1/agent/agent.proto 213c428d424d8e4f0cc07bd86f1ed59b60df107c 
  src/slave/http.cpp 21c7ebf7c23fd06bee7125c90576eb892b249b4d 
  src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 

Diff: https://reviews.apache.org/r/49939/diff/


Testing
-------

Modified AgentAPITest.GetMetrics to make sure we return metrics grouped by types.


1. Run master: ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
2. Run agent: ./bin/mesos-slave.sh --master=127.0.0.1:5050 --work_dir=/var/lib/mesos
2. Call GET_METRICS: curl --header "Content-Type:application/json" --data '{"type": "GET_METRICS",
"get_metrics":{}}' http://localhost:5051/api/v1 | python -m json.tool


Thanks,

Tuan-Anh Hoang-Vu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message