mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tuan-Anh Hoang-Vu <hvtuan...@gmail.com>
Subject Re: Review Request 49938: Updated GET_METRICS call in v1 api to return metrics grouped by types.
Date Thu, 14 Jul 2016 20:38:27 GMT


> On July 14, 2016, 1:47 a.m., Abhishek Dasgupta wrote:
> > src/master/http.cpp, lines 1916-1944
> > <https://reviews.apache.org/r/49938/diff/1/?file=1441927#file1441927line1916>
> >
> >     Can we consider to use a switch here?

I don't know why I can't use foreachpair for MetricMap. I got this error message:

../../src/master/http.cpp:1918:94: error: macro "foreachpair" passed 4 arguments, but takes
just 3
         foreachpair (const MetricType metricType, hashmap<string, double> metrics,
metricsMap) {


- Tuan-Anh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49938/#review142209
-----------------------------------------------------------


On July 14, 2016, 1:31 p.m., Tuan-Anh Hoang-Vu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49938/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 1:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-5731
>     https://issues.apache.org/jira/browse/MESOS-5731
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated GET_METRICS call in v1 api to return metrics grouped by types.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 7fb7153b5498a55469d2c72873c45fb534c0e60d 
>   include/mesos/v1/master/master.proto c9e4359fff018de55d83da5cde0eb6d59dacfc3e 
>   src/master/http.cpp 42ba3643daf8f6fe63152178214b57e3b773d93e 
>   src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 
> 
> Diff: https://reviews.apache.org/r/49938/diff/
> 
> 
> Testing
> -------
> 
> Modified MasterAPITest.GetMetrics to make sure we return metrics grouped by types.
> 
> 
> 1. Run master: ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> 2. Call GET_METRICS: curl --header "Content-Type:application/json" --data '{"type": "GET_METRICS",
"get_metrics":{}}' http://localhost:5050/api/v1 | python -m json.tool
> 
> 
> Thanks,
> 
> Tuan-Anh Hoang-Vu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message