mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50022: Fixed incorrected command in documentation.
Date Thu, 14 Jul 2016 11:32:51 GMT


> On 七月 14, 2016, 10:35 a.m., Guangya Liu wrote:
> > I think we should not merge this, the mesos-execute should use mesos containerizer
but not docker containerizer here, comments?
> 
> Joerg Schad wrote:
>     Good point. I was mostly concerned with the command not working. I will check with
containerizers=mesos and then update.

The default containerizer in mesos-execute is `mesos`, so you do not need to specify it in
the command. Adding `containerizr=docker` here will cause task launch failed cause the agent
default `containerizer` is `mesos`.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50022/#review142220
-----------------------------------------------------------


On 七月 14, 2016, 8:32 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50022/
> -----------------------------------------------------------
> 
> (Updated 七月 14, 2016, 8:32 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Command was not working as specified, we need
> to specify the containerizer parameter.
> 
> 
> Diffs
> -----
> 
>   docs/container-image.md 745f6b045d11de6f54323347ebadac9e3ae6cab2 
> 
> Diff: https://reviews.apache.org/r/50022/diff/
> 
> 
> Testing
> -------
> 
> Viewed via gist: https://gist.github.com/joerg84/aec465f898b9186aa3c26acad7671d20
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message