mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 49939: Updated GET_METRICS call in AGENT v1 api to return metrics grouped by types.
Date Thu, 14 Jul 2016 10:23:27 GMT


> On July 14, 2016, 7:31 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [49939, 49938, 49937, 49936]
> > 
> > Failed command: ./support/apply-review.sh -n -r 49938
> > 
> > Error:
> > 2016-07-14 07:31:47 URL:https://reviews.apache.org/r/49938/diff/raw/ [4422/4422]
-> "49938.patch" [1]
> > Total errors found: 0
> > Checking 2 files
> > Error: No line in the commit message summary may exceed 72 characters.
> > 
> > Full log: https://builds.apache.org/job/mesos-reviewbot/14309/console

I think the problem will be solved if you divide the description section for this review(and
r449938) into two lines where each containing not more than 72 characters. Thank you for your
contribution.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49939/#review142200
-----------------------------------------------------------


On July 12, 2016, 2:04 a.m., Tuan-Anh Hoang-Vu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49939/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 2:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-5731
>     https://issues.apache.org/jira/browse/MESOS-5731
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated GET_METRICS call in agent v1 api to return metrics grouped by types.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto cfd117de81396bf79049b7642f1ccd1ff4fbb676 
>   include/mesos/v1/agent/agent.proto 213c428d424d8e4f0cc07bd86f1ed59b60df107c 
>   src/slave/http.cpp 21c7ebf7c23fd06bee7125c90576eb892b249b4d 
>   src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 
> 
> Diff: https://reviews.apache.org/r/49939/diff/
> 
> 
> Testing
> -------
> 
> Modified AgentAPITest.GetMetrics to make sure we return metrics grouped by types.
> 
> 
> 1. Run master: ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> 2. Run agent: ./bin/mesos-slave.sh --master=127.0.0.1:5050 --work_dir=/var/lib/mesos
> 2. Call GET_METRICS: curl --header "Content-Type:application/json" --data '{"type": "GET_METRICS",
"get_metrics":{}}' http://localhost:5051/api/v1 | python -m json.tool
> 
> 
> Thanks,
> 
> Tuan-Anh Hoang-Vu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message