mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 42441: Speeded up the `ExamplesTest.*` test cases.
Date Thu, 14 Jul 2016 10:00:46 GMT


> On July 13, 2016, 11:30 p.m., Benjamin Mahler wrote:
> > The patch looks good, thanks! However, the summary and description are not precise.
> > 
> > This change could be described as the following two changes:
> > 
> > (1) Made the scheduler authentication timeout configurable.
> > (2) Speed up the examples tests. (description can say why lowering the authentication
timeout helps).
> > 
> > Can you make the adjustments based on the comments below and split the patch? We
should then be set to commit this. Thanks haosdent!

Hi, @bmahler Thanks a lot for your reviews. Just updated.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42441/#review142152
-----------------------------------------------------------


On July 14, 2016, 9:58 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42441/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 9:58 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jian Qiu.
> 
> 
> Bugs: MESOS-4155
>     https://issues.apache.org/jira/browse/MESOS-4155
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This lowers the scheduler authentication timeout to speed up the
> `ExamplesTest.*` test cases. Because the master may drop the
> authentication message from the scheduler while it is recovering,
> lowering the authentication timeout could speed up the scheduler
> retries to connect the master.
> 
> 
> Diffs
> -----
> 
>   src/tests/dynamic_reservation_framework_test.sh 448dfee8704e39a552fbe2340de6fd1be20b5950

>   src/tests/java_exception_test.sh fd02322096d09cee6cc22340f18681ad372867b5 
>   src/tests/java_framework_test.sh 8fccc699133c6db6130153c367ce01ba3931c1a2 
>   src/tests/no_executor_framework_test.sh 4fa154ee52454fe3f56161abaa29e58793e627e3 
>   src/tests/persistent_volume_framework_test.sh 074cdcbc4a738170e84887c1773cd7c118112d58

>   src/tests/python_framework_test.sh dc3a50f4fe8d3340429996622e62f732941985a2 
>   src/tests/test_framework_test.sh 617ca5283bd626b535d0f8091bd1d622d175f6d8 
>   src/tests/test_http_framework_test.sh 0e04ff689d008dea5d2e565b0c58096ecdd24b08 
> 
> Diff: https://reviews.apache.org/r/42441/diff/
> 
> 
> Testing
> -------
> 
> Repeat test in CentOS 7.1
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message