mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 50024: WIP: Used same authn flag sanity checks for master as in agent.
Date Thu, 14 Jul 2016 09:01:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50024/
-----------------------------------------------------------

Review request for mesos and Adam B.


Bugs: MESOS-5343
    https://issues.apache.org/jira/browse/MESOS-5343


Repository: mesos


Description
-------

The agent would perform a number of checks on user-provided
authentication flags in order to catch potentially unintended
configurations, in particular it would reject settings with either
HTTP credentials or HTTP authenticators set, but without
authentication explicitly enabled.

The master on the other hand would have silently accept these
settings, even though they lead to no effect (possibly to the user's
surprise).

This patch enables the existing sanity checks for flags to the agent
also for the master.


Diffs
-----

  src/master/master.cpp 79e3d78ba45060bc2f2532fdc3d105d1cc888d0f 

Diff: https://reviews.apache.org/r/50024/diff/


Testing
-------

THIS IS A WIP PATCH AND SHOULD NOT BE COMMITTED AT THIS POINT.

This patch just harmonizes the flag validation behavior, but currently
causes numerous failures since tests do not set up correct flags. We
should first clean up the way tests specify flags and then apply this
patch on top to actually enforce semantics


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message