mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 50019: Ensured that framework IDs are quoted consistency in log messages.
Date Thu, 14 Jul 2016 07:58:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50019/
-----------------------------------------------------------

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
-------

Framework IDs are assigned by the master, so we know they follow a
predictable format that does not contain whitespace. Hence, when
including framework IDs in log messages, we don't need to quote
them. Most places in the codebase didn't use quotes, but a few places
did; this commit removes the single quotes from the latter.


Diffs
-----

  src/cli/execute.cpp ee26f02cbac0cef5e77b536a5842e5ea4bf27ea2 
  src/examples/test_http_framework.cpp cf6baed07c862ccade080618f33cc921fc09415d 
  src/master/http.cpp d1fe22bd2d9eb6bd82e32cf01720bbe3d8be26d5 
  src/sched/sched.cpp b9315b53dfbe86500ad1643cc7dfd0f9d6f6a32a 
  src/slave/containerizer/docker.cpp f1ecf3b25d85597f6c3dcaa47968860ed119dbd5 
  src/slave/containerizer/mesos/containerizer.cpp e900d752b70165236a198f70c8cb24876a678e4b


Diff: https://reviews.apache.org/r/50019/diff/


Testing
-------

make check, visual inspection


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message