mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.
Date Thu, 14 Jul 2016 00:21:10 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 13, 2016, 5:21 p.m.)

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Rebase and revive the chain.  This does not address any comments.

Bugs: MESOS-3910

Repository: mesos

Description (updated)

The `SocketManager` and `ProcessManager` are highly inter-dependent, 
which requires some untangling in `process::finalize`.

* Logic originally found in `~ProcessManager` has been split into 
  `ProcessManager::finalize` due to what happens during cleanup.
* The future from `__s__->accept()` must be explicitly discarded as 
  libevent does not detect a locally closed socket.
* Terminating `HttpProxy`s must close the associated socket.

Diffs (updated)

  3rdparty/libprocess/src/process.cpp 9661386afd4fddd1877d55941fa403afc9230280 



`make check` (libev)
`make check` (--enable-libevent --enable-ssl)


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message