> On July 13, 2016, 7:08 a.m., Guangya Liu wrote:
> > src/docker/docker.cpp, lines 568-570
> > <https://reviews.apache.org/r/49961/diff/1/?file=1442433#file1442433line568>
> >
> > why this does not work if I was using relative path for both? Here the relative
container_path will be updated to absolute path above and if the host path is relative path,
it means it is using volume from volume driver, why guard this case?
>
> Jie Yu wrote:
> I think volume driver is being deprecated. The logics here was hacky from the very
begining. Since relative container_path is not support anyway previously, let's don't introduce
a behavior that we will deprecate soon.
>
> Guangya Liu wrote:
> Yes, the option "--volume-driver" is being deprecated, but I saw that we already
translated the container path from `relative path` to `absolute path` in line 562-564, and
here a `relative host path` means the docker volume is created by `docker volume create` with
docker volume driver, not sure why such case was rejected? ;-)
Previously, before this patch, if both host_path and container_path is relative, and volume
driver is specified, it won't work. It'll be something like the following and docker daemon
will give you an error.
```
-v volume:data --volume-driver=rexray
```
The check here simply disallow that.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49961/#review142022
-----------------------------------------------------------
On July 13, 2016, 7:26 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49961/
> -----------------------------------------------------------
>
> (Updated July 13, 2016, 7:26 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-5389
> https://issues.apache.org/jira/browse/MESOS-5389
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported relative container path in docker containerizer.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e96b4b64e205946eefd1af87832fca1a45aa8ba4
>
> Diff: https://reviews.apache.org/r/49961/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
|