mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49961: Supported relative container path in docker containerizer.
Date Wed, 13 Jul 2016 23:47:10 GMT


> On July 13, 2016, 7:08 a.m., Guangya Liu wrote:
> > src/docker/docker.cpp, line 562
> > <https://reviews.apache.org/r/49961/diff/1/?file=1442433#file1442433line562>
> >
> >     what about `path::absolute(volume.container_path())`?
> 
> Jie Yu wrote:
>     +1
> 
> Guangya Liu wrote:
>     I saw that the code was merged but not using `path::absolute(volume.container_path())`,
does there are any reason we do not use this?

Yeah, i asked Gilbert to follow up with a patch to do a sweep in this file.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49961/#review142022
-----------------------------------------------------------


On July 13, 2016, 7:26 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49961/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 7:26 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-5389
>     https://issues.apache.org/jira/browse/MESOS-5389
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported relative container path in docker containerizer.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp e96b4b64e205946eefd1af87832fca1a45aa8ba4 
> 
> Diff: https://reviews.apache.org/r/49961/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message