mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 42441: Decrease scheduler authenticate timeout.
Date Wed, 13 Jul 2016 23:30:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42441/#review142152
-----------------------------------------------------------



The patch looks good, thanks! However, the summary and description are not precise.

This change could be described as the following two changes:

(1) Made the scheduler authentication timeout configurable.
(2) Speed up the examples tests. (description can say why lowering the authentication timeout
helps).

Can you make the adjustments based on the comments below and split the patch? We should then
be set to commit this. Thanks haosdent!


src/sched/constants.hpp (line 52)
<https://reviews.apache.org/r/42441/#comment207671>

    ```
    // Default value for --authentication_timeout.
    ```



src/sched/constants.hpp (line 53)
<https://reviews.apache.org/r/42441/#comment207669>

    To match the other naming (e.g. DEFAULT_AUTHENTICATION_BACKOFF_FACTOR):
    
    s/AUTHENTICATE/AUTHENTICATION/



src/sched/flags.hpp (lines 122 - 125)
<https://reviews.apache.org/r/42441/#comment207675>

    s/authenticate/authentication/
    
    For the help string:
    
    Timeout after which authentication will be retried.



src/sched/flags.hpp (line 133)
<https://reviews.apache.org/r/42441/#comment207676>

    authentication here and elsewhere



src/tests/java_exception_test.sh (line 24)
<https://reviews.apache.org/r/42441/#comment207678>

    How about:
    
    ```
    # Lower the authentication timeout to speed up the test (the master
    # may drop the authentication message while it is recovering).
    ```
    
    Ditto in the other tests.


- Benjamin Mahler


On July 13, 2016, 1:54 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42441/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 1:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jian Qiu.
> 
> 
> Bugs: MESOS-4155
>     https://issues.apache.org/jira/browse/MESOS-4155
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Decrease scheduler authenticate timeout.
> 
> 
> Diffs
> -----
> 
>   src/sched/constants.hpp 75973c97c20927cd18b531cbeab2bf6f69d5538c 
>   src/sched/flags.hpp 43b38d733e963aafc81d69d56569ff20ce8bffa6 
>   src/sched/sched.cpp b9315b53dfbe86500ad1643cc7dfd0f9d6f6a32a 
>   src/tests/java_exception_test.sh fd02322096d09cee6cc22340f18681ad372867b5 
>   src/tests/java_framework_test.sh 8fccc699133c6db6130153c367ce01ba3931c1a2 
>   src/tests/no_executor_framework_test.sh 4fa154ee52454fe3f56161abaa29e58793e627e3 
>   src/tests/persistent_volume_framework_test.sh 074cdcbc4a738170e84887c1773cd7c118112d58

>   src/tests/python_framework_test.sh dc3a50f4fe8d3340429996622e62f732941985a2 
>   src/tests/test_framework_test.sh 617ca5283bd626b535d0f8091bd1d622d175f6d8 
>   src/tests/test_http_framework_test.sh 0e04ff689d008dea5d2e565b0c58096ecdd24b08 
> 
> Diff: https://reviews.apache.org/r/42441/diff/
> 
> 
> Testing
> -------
> 
> Repeat test in CentOS 7.1
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message