mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.
Date Wed, 13 Jul 2016 23:10:49 GMT


> On July 12, 2016, 9:25 a.m., Neil Conway wrote:
> > Is this change still necessary, given the changes in https://reviews.apache.org/r/48313
? I'd prefer to keep the ability to create `MOUNT` volumes on existing filesystem content.
> 
> Anindya Sinha wrote:
>     Without this change, we run the possibility of exposing data from a different persistent
volume to another framework (role) which is not desirable.
>     Do you think we can limit the check if the persistent volume being created is of
type MOUNT? Basically, enforce the check (as in this RR) to volumes being created of type
!= MOUNT, and preserve the original functionality for volumes being created for MOUNT disks?
> 
> Neil Conway wrote:
>     Can you describe how we run the risk of exposing data from a different persistent
volume if the changes in r48313 are implemented?

I agree with you. There does not seem to be a case when we need to disallow `CREATE` for non-empty
path. I think we had this patch when we were not crashing the agent on failure to do a `rmdir()`
as a part of a `DESTROY`. Now that we do not let the agent come up until `rmdir()` for the
persistent volume is successfully destroyed, I think we are good to go just with https://reviews.apache.org/r/48313,
and close https://reviews.apache.org/r/48314 and this RR (https://reviews.apache.org/r/48315).


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48315/#review141870
-----------------------------------------------------------


On July 1, 2016, 9:41 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48315/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 9:41 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5448
>     https://issues.apache.org/jira/browse/MESOS-5448
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Root of a MOUNT disk is not deleted on volume DELETE. When we do a
> CREATE on a persistent volume and the root directory exists (which
> can happen for MOUNT disks), we allow the operation only if the
> contents within the root directory is empty. If not, we do not update
> the checkpoint with this volume and exit, so as to cleanup when the
> slave restarts and handles the CheckpointResourcesMessage.
> 
> 
> Diffs
> -----
> 
>   docs/multiple-disk.md 20b99e0e57360ad43804201b27e593d7ed48ce2c 
>   src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22 
>   src/tests/persistent_volume_tests.cpp 5125a8da44759d1235fddac26e9eb5436c3d037b 
> 
> Diff: https://reviews.apache.org/r/48315/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message