mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49348: Added implementation to Appc Runtime Isolator.
Date Wed, 13 Jul 2016 23:06:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49348/#review142145
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 210)
<https://reviews.apache.org/r/49348/#comment207651>

    Could we add one more dash?



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 260)
<https://reviews.apache.org/r/49348/#comment207653>

    We can use it as a ref here.
    
    const appc::spec::ImageManifest::App& app



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (lines 264 - 272)
<https://reviews.apache.org/r/49348/#comment207655>

    Just realize a bug here. We use `execvp` to execute non-shell command, so the value (exec[0]
here) has to be included as the first arguments. Please see docker runtime isolator for example.
    
    So currently it is not supposed to work correctly. Did we test this isolator with the
cases line#1 and lind#2 ?


- Gilbert Song


On July 13, 2016, 3:26 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49348/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation to Appc Runtime Isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message