-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45999/#review142099
-----------------------------------------------------------
Ship it!
Note: I replaced `NULL` with `nullptr` prior to committing.
- Joseph Wu
On June 2, 2016, 1:30 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45999/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 1:30 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-5144
> https://issues.apache.org/jira/browse/MESOS-5144
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Without this change, `finalize()` terminates processes in the order
> that they happen to be found when iterating over the `processes`
> map. That means that if the GarbageCollector process is terminated
> while any GC-managed processes are still running, those processes
> will not be GC'd (i.e., they will be leaked).
>
> Fix this by skipping the garbage collector process when iterating
> over `processes` in `finalize()`, and then only terminating it after
> all other processes have been terminated.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp be120fb85583d438401c24a57dac803be3b5e5d2
>
> Diff: https://reviews.apache.org/r/45999/diff/
>
>
> Testing
> -------
>
> make check
>
> Confirmed reduction of leaked memory via ASAN on Linux/amd64.
>
>
> Thanks,
>
> Neil Conway
>
>
|