mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49208: Added tests to check if appc spec is properly parsed.
Date Wed, 13 Jul 2016 18:21:06 GMT


> On July 13, 2016, 11 a.m., Gilbert Song wrote:
> > src/tests/containerizer/appc_spec_tests.cpp, lines 227-228
> > <https://reviews.apache.org/r/49208/diff/8/?file=1442379#file1442379line227>
> >
> >     ```
> >       EXPECT_EQ(
> >           imageManifest->annotations(0).value(),
> >           "acbuild set-name \"example.com/hello\"");```

I meant:

EXPECT_EQ(
    imageManifest->annotations(0).value(),
    "acbuild set-name \"example.com/hello\"");


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49208/#review142087
-----------------------------------------------------------


On July 12, 2016, 9:14 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49208/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 9:14 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests to check if appc spec is properly parsed.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 599ebbef6d164fb2a530b55427ddabb5cd607634 
>   src/tests/containerizer/appc_spec_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_appc_tests.cpp 061f80c62319817b22a5c1880a4858fdafbfb72a

> 
> Diff: https://reviews.apache.org/r/49208/diff/
> 
> 
> Testing
> -------
> 
> Make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message