mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49208: Added tests to check if appc spec is properly parsed.
Date Wed, 13 Jul 2016 07:32:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49208/#review142025
-----------------------------------------------------------




src/tests/containerizer/appc_spec_tests.cpp (lines 77 - 80)
<https://reviews.apache.org/r/49208/#comment207497>

    Please update here as this:
    
    ```javascript
    ASSERT_SOME(json);
    
    Try<spec::ImageManifest> imageManifest = spec::parse(stringify(json.get()));
    ASSERT_SOME(imageManifest);
    ```



src/tests/containerizer/appc_spec_tests.cpp (lines 107 - 108)
<https://reviews.apache.org/r/49208/#comment207498>

    new line here



src/tests/containerizer/appc_spec_tests.cpp (lines 125 - 129)
<https://reviews.apache.org/r/49208/#comment207499>

    Please update as this:
    
    ```javascript
    ASSERT_SOME(json);
    
    Try<spec::ImageManifest> manifest = spec::parse(stringify(json.get()));
    ASSERT_SOME(manifest);
    
    ASSERT_SOME(os::write(path::join(image, "manifest"), stringify(json.get())));
    ```



src/tests/containerizer/appc_spec_tests.cpp (lines 213 - 216)
<https://reviews.apache.org/r/49208/#comment207500>

    Please update as following:
    
    ```javascript
    ASSERT_SOME(json);
    
    Try<spec::ImageManifest> imageManifest = spec::parse(stringify(json.get()));
    ASSERT_SOME(imageManifest);
    ```



src/tests/containerizer/appc_spec_tests.cpp (line 228)
<https://reviews.apache.org/r/49208/#comment207501>

    keep align with `imageManifest->annotations(0).value(),`
    
    ```javascript
     EXPECT_EQ(imageManifest->annotations(0).value(),
               "acbuild set-name \"example.com/hello\"");
    ```



src/tests/containerizer/provisioner_appc_tests.cpp (line 76)
<https://reviews.apache.org/r/49208/#comment207502>

    kill this line


- Guangya Liu


On 七月 12, 2016, 4:14 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49208/
> -----------------------------------------------------------
> 
> (Updated 七月 12, 2016, 4:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests to check if appc spec is properly parsed.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 599ebbef6d164fb2a530b55427ddabb5cd607634 
>   src/tests/containerizer/appc_spec_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_appc_tests.cpp 061f80c62319817b22a5c1880a4858fdafbfb72a

> 
> Diff: https://reviews.apache.org/r/49208/diff/
> 
> 
> Testing
> -------
> 
> Make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message