mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49781: Code cleanup in hierarchical_allocator_tests.cpp.
Date Wed, 13 Jul 2016 02:48:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49781/#review141999
-----------------------------------------------------------



Patch looks great!

Reviews applied: [49943, 49781]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 13, 2016, 1:27 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49781/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 1:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5800
>     https://issues.apache.org/jira/browse/MESOS-5800
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixed the following issues in benchmark test:
> 1) Enabled emplatized test fixture for DeclineOffers and
> ResourceLabels.
> 2) Updated the output for the benchmark to be more clear.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 153c9b4cf4819e976910c5a7ad9602028e2d22eb

> 
> Diff: https://reviews.apache.org/r/49781/diff/
> 
> 
> Testing
> -------
> 
> LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-tests.sh --benchmark --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1”
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1
> Using 1000 agents and 50 frameworks
> round 0 allocate() took 2.318337secs to make 1000 offers
> round 1 allocate() took 2.409893secs to make 1000 offers
> round 2 allocate() took 2.321126secs to make 1000 offers
> round 3 allocate() took 2.395405secs to make 1000 offers
> round 4 allocate() took 2.374936secs to make 1000 offers
> round 5 allocate() took 2.440044secs to make 1000 offers
> round 6 allocate() took 2.439823secs to make 1000 offers
> round 7 allocate() took 2.487971secs to make 1000 offers
> round 8 allocate() took 2.481203secs to make 1000 offers
> round 9 allocate() took 2.527503secs to make 1000 offers
> round 10 allocate() took 2.541704secs to make 1000 offers
> round 11 allocate() took 2.6053secs to make 1000 offers
> round 12 allocate() took 2.734203secs to make 1000 offers
> …
> 
> LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-tests.sh --benchmark --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1”
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1
> Using 1000 agents and 50 frameworks
> round 0 allocate() took 2.557151secs to make 1000 offers
> round 1 allocate() took 2.538777secs to make 1000 offers
> round 2 allocate() took 2.492293secs to make 1000 offers
> round 3 allocate() took 2.515341secs to make 1000 offers
> round 4 allocate() took 2.629221secs to make 1000 offers
> round 5 allocate() took 2.701026secs to make 1000 offers
> round 6 allocate() took 2.596663secs to make 1000 offers
> round 7 allocate() took 2.696374secs to make 1000 offers
> …
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message