mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Srinivas Brahmaroutu <srbra...@us.ibm.com>
Subject Re: Review Request 49688: Added cmake build for mesos tests.
Date Wed, 13 Jul 2016 00:37:48 GMT


> On July 12, 2016, 4:23 a.m., Alex Clemmer wrote:
> > src/tests/CMakeLists.txt, line 156
> > <https://reviews.apache.org/r/49688/diff/5/?file=1441338#file1441338line156>
> >
> >     Also, I think this is not the right command to run for Mesos tests -- can you
confirm? The same goes for the containerizer memory tests. Running `make test` fails on my
OS X 10.10 machine, with the following error:
> >     
> >     ```
> >     /usr/local/Cellar/cmake/3.4.0/bin/ctest --force-new-ctest-process
> >     Test project /Users/alex/src/mesos/build
> >         Start 1: StoutTests
> >     1/4 Test #1: StoutTests .......................   Passed    0.45 sec
> >         Start 2: ProcessTests
> >     2/4 Test #2: ProcessTests .....................   Passed    1.74 sec
> >         Start 3: MesosTests
> >     3/4 Test #3: MesosTests .......................***Failed    0.31 sec
> >     Usage: /Users/alex/src/mesos/build/src/tests/mesos-tests <expected username>
> >     
> >         Start 4: MesosContainerizerMemoryTests
> >     4/4 Test #4: MesosContainerizerMemoryTests ....***Failed    0.05 sec
> >     Usage: /Users/alex/src/mesos/build/src/tests/containerizer/mesos-containerizer-memory_test
<subcommand> [OPTIONS]
> >     
> >     Available subcommands:
> >         help
> >         MemoryTestHelperMain
> >     
> >     
> >     
> >     50% tests passed, 2 tests failed out of 4
> >     
> >     Total Test time (real) =   2.56 sec
> >     
> >     The following tests FAILED:
> >     	  3 - MesosTests (Failed)
> >     	  4 - MesosContainerizerMemoryTests (Failed)
> >     Errors while running CTest
> >     ```
> >     
> >     We will need to fix this before we check in.

Intention is not to run any tests in this patch. I require other dependencies from examples,
etc to run the code without changin source code. What we are building is a dummy executable
with only utility classes and the 'main' coming from 'active_user_test_helper.cpp'. That patched
are lined up to make a meaningful 'mesos-tests' in the end. If you think we do it the other
way, I will submit individual patches for examples modules first and then send in this patch.


- Srinivas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49688/#review141840
-----------------------------------------------------------


On July 12, 2016, 4:26 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49688/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 4:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added cmake build for mesos tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 
>   src/tests/cmake/TestsConfigure.cmake PRE-CREATION 
>   src/tests/containerizer/CMakeLists.txt dab8cb07f09f5554123ede4ec8b45b60abf62eee 
> 
> Diff: https://reviews.apache.org/r/49688/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> cmake check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message