mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 45966: Offer shareable resources to frameworks only if opted in.
Date Tue, 12 Jul 2016 22:56:36 GMT


> On July 12, 2016, 9:04 p.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, line 292
> > <https://reviews.apache.org/r/45966/diff/6/?file=1435466#file1435466line292>
> >
> >     s/shareable/shared/ here and elsewhere in comments.

Fixed in https://reviews.apache.org/r/49967/.


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45966/#review141949
-----------------------------------------------------------


On July 1, 2016, 10:29 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45966/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 10:29 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4325
>     https://issues.apache.org/jira/browse/MESOS-4325
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new capability SHAREABLE_RESOURCES that frameworks need to opt
> in if they are interested in receiving shared resources in their
> offers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 
>   include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 
>   src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
>   src/master/allocator/mesos/hierarchical.hpp b72ba16277a3210e4d309b616d185a10e2029a66

>   src/master/allocator/mesos/hierarchical.cpp eca949e07abb00423a2f35a56eedc5d4287d81f3

>   src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179

> 
> Diff: https://reviews.apache.org/r/45966/diff/
> 
> 
> Testing
> -------
> 
> Tests updated with new capability.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message