mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 49958: Fixed Docker daemon args generation.
Date Tue, 12 Jul 2016 21:15:09 GMT


> On July 12, 2016, 8:53 p.m., Gilbert Song wrote:
> > src/docker/docker.cpp, lines 620-631
> > <https://reviews.apache.org/r/49958/diff/1/?file=1442438#file1442438line620>
> >
> >     Should we consider just deprecate `DockerInfo.volume_driver` in this patch?
Since 1.0 will be released these couple days.

It is already deprecated, see: https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L1839


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49958/#review141962
-----------------------------------------------------------


On July 12, 2016, 5:04 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49958/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 5:04 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5834
>     https://issues.apache.org/jira/browse/MESOS-5834
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix prevents the Docker containerizer from specifying
> --volume_driver multiple times.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp aad5380f5848f1b49d5524032f3b5b18c2aa1c56 
>   src/tests/containerizer/docker_tests.cpp 00ccc2fc54a984f3a67573ce6fe7aee3e60ce3a2 
> 
> Diff: https://reviews.apache.org/r/49958/diff/
> 
> 
> Testing
> -------
> 
> Added two new tests and they pass.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message