mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.
Date Tue, 12 Jul 2016 18:06:20 GMT


> On July 12, 2016, 12:35 p.m., Neil Conway wrote:
> > Seems like this review contains a bunch of changes, in addition to lowering the
`allocation_interval`. Are these changes related? Can you move the unrelated changes to a
separate review, and/or explain why you have made them?

Actually, all of the changes were needed for speeding up the test. Still after lowering the
allocation_interval, UnreserveResource Test was slow and it speeded up after removing unnecessary
tests for varifying if the resources were unreserved. Do you still think it would be good
to make these two changes in separate patches?


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49914/#review141889
-----------------------------------------------------------


On July 11, 2016, 7:39 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49914/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 7:39 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5732
>     https://issues.apache.org/jira/browse/MESOS-5732
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Overloaded createMasterFlags in MasterAPITest to increase
> the speed of 'MasterAPITest.ReserveResources' and
> 'MasterAPITest.UnreserveResources'.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 
> 
> Diff: https://reviews.apache.org/r/49914/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message