mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 49781: Code cleanup in hierarchical_allocator_tests.cpp.
Date Tue, 12 Jul 2016 17:52:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49781/#review141927
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/hierarchical_allocator_tests.cpp (lines 3481 - 3483)
<https://reviews.apache.org/r/49781/#comment207362>

    Can we keep the "round #" info in this test? 
    
    In the new SuppressOffers test we use the number of suppressed frameworks to distinguish
the rounds explicitly but for this test we only have the round # (until we determine how to
refactor this test). When there are thousands of lines printed out the round # helps us infer
what the cluster state a particular line corresponds to (which is very implicit but for the
clean up let's keep it this way).



src/tests/hierarchical_allocator_tests.cpp (lines 3632 - 3634)
<https://reviews.apache.org/r/49781/#comment207363>

    Ditto.


- Jiang Yan Xu


On July 11, 2016, 7:01 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49781/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 7:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5800
>     https://issues.apache.org/jira/browse/MESOS-5800
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixed the following issues in benchmark test:
> 1) Enabled emplatized test fixture for DeclineOffers and
> ResourceLabels.
> 2) Updated the output for the benchmark to be more clear.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 153c9b4cf4819e976910c5a7ad9602028e2d22eb

> 
> Diff: https://reviews.apache.org/r/49781/diff/
> 
> 
> Testing
> -------
> 
> LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-tests.sh --benchmark --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1”
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1
> Using 1000 agents and 50 frameworks
>  allocate() took 625869us to make 1000 offers
>  allocate() took 628127us to make 1000 offers
>  allocate() took 618838us to make 1000 offers
>  allocate() took 595152us to make 1000 offers
>  allocate() took 622273us to make 1000 offers
>  allocate() took 595577us to make 1000 offers
>  allocate() took 628503us to make 1000 offers
>  allocate() took 623374us to make 1000 offers
> ….
> 
> LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-tests.sh --benchmark --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1”
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1
> Using 1000 agents and 50 frameworks
>  allocate() took 670083us to make 1000 offers
>  allocate() took 665393us to make 1000 offers
>  allocate() took 635591us to make 1000 offers
>  allocate() took 691869us to make 1000 offers
> ….
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message