mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 49736: Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.
Date Tue, 12 Jul 2016 16:40:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49736/#review141913
-----------------------------------------------------------




3rdparty/CMakeLists.txt (line 141)
<https://reviews.apache.org/r/49736/#comment207325>

    This probably won't work on Windows. You will notice that for (_e.g._) `HTTP_PARSER_PATCH_CMD`,
we have something like this instead of `PATCH_CMD`:
    
    ```
      set(HTTP_PARSER_PATCH_CMD ${PATCHEXE_LOCATION} --binary -p1 < ${MESOS_3RDPARTY_BIN}/http-parser-${HTTP_PARSER_VERSION}.patch)
    ```
    
    This is pretty unfortuante and as I look at this file, it seems like we're not patching
a lot of the libraries. This is probably my doing. #clowntown I've filed an issue to make
sure we follow up on this: MESOS-5835


- Alex Clemmer


On July 6, 2016, 11:58 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49736/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt a7ae76a40fcf5c6d6c9dc86daaa7524c220980dd 
> 
> Diff: https://reviews.apache.org/r/49736/diff/
> 
> 
> Testing
> -------
> 
> $ cmake ..
> $ make -j
> $ make -j check
> 
> Manually inspected: `3rdparty/elfio-3.1/src/elfio-3.1/elfio/elfio_note.hpp`
> and saw that the patch is applied.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message