mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49784: Increase framework numbers to allocator benchmarks.
Date Tue, 12 Jul 2016 04:32:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49784/#review141843
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (line 3196)
<https://reviews.apache.org/r/49784/#comment207241>

    Two issues for this patch:
    
    1) The new added framework number will introduce some cases that agent number is less
than framework number and some frameworks may not able to get resources.
    2) This will slow down the unit test, it is better introduce this and fix https://issues.apache.org/jira/browse/MESOS-4558
together by introducing `batchsize` for benchmark test.


- Guangya Liu


On July 8, 2016, 4:02 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49784/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 4:02 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5780 and MESOS-5781
>     https://issues.apache.org/jira/browse/MESOS-5780
>     https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Our clusters have very high numbers of frameworks,
>   and we would like to increase the allocator benchmark
>   parameters to reflect this.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 0498cd5e54b0e4b87a767585a77699653aa52179

> 
> Diff: https://reviews.apache.org/r/49784/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message