mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.
Date Tue, 12 Jul 2016 02:24:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49913/#review141832
-----------------------------------------------------------




src/tests/mesos.hpp (line 582)
<https://reviews.apache.org/r/49913/#comment207221>

    why `role1` but not `role`?


- Jay Guo


On July 11, 2016, 7:12 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49913/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 7:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5725
>     https://issues.apache.org/jira/browse/MESOS-5725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clean up code to define createFrameworkInfo() once in
> tests/mesos.hpp and use that in various other inherited
> tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 
>   src/tests/mesos.hpp e4eccfc3810bed3649a3ab80e252849470de4c72 
>   src/tests/persistent_volume_endpoints_tests.cpp 2a22f3b0da817e650a25e5e2c951adb7462718b4

>   src/tests/reservation_endpoints_tests.cpp 48c002d1dc371c285b9421ef5a2c57250d270fa8

> 
> Diff: https://reviews.apache.org/r/49913/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message