mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tuan-Anh Hoang-Vu <hvtuan...@gmail.com>
Subject Review Request 49936: Added metric types in libprocess.
Date Tue, 12 Jul 2016 02:02:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49936/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Vinod Kone.


Bugs: MESOS-5731
    https://issues.apache.org/jira/browse/MESOS-5731


Repository: mesos


Description
-------

Added metric types in libprocess.


Diffs
-----

  3rdparty/libprocess/include/process/metrics/counter.hpp a13cc7e18c8b23eae83c326d63874d9d2aaedc0d

  3rdparty/libprocess/include/process/metrics/gauge.hpp c5bbeaf5d53c60f3636d1778db47cdb6cdda34e8

  3rdparty/libprocess/include/process/metrics/metric.hpp 21f162d5b7d9e56dc3289d65b6d86deb4c2fa721

  3rdparty/libprocess/include/process/metrics/timer.hpp 0a9c0227c457c6c81a59f65f901a5464ee00983d

  3rdparty/libprocess/src/tests/metrics_tests.cpp 5a82f4f49aecd03d12687de629516be5b7895036


Diff: https://reviews.apache.org/r/49936/diff/


Testing
-------

Modified MetricsTest.Counter, MetricsTest.Gauge and MetricsTest.Timer to make sure we set
metric types correctly when creating them.


Thanks,

Tuan-Anh Hoang-Vu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message