mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 49926: Added Windows build batch script.
Date Tue, 12 Jul 2016 01:10:47 GMT


> On July 11, 2016, 5:35 p.m., Daniel Pravat wrote:
> > support/windows-build.bat, line 71
> > <https://reviews.apache.org/r/49926/diff/1/?file=1441664#file1441664line71>
> >
> >     If you add one more target Clean  you don't need to delete any folder.

Do you mean the "build/include" and "build/src" folders?  I've already committed the fix for
MESOS-5756, so those are no longer necessary.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49926/#review141804
-----------------------------------------------------------


On July 11, 2016, 3:19 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49926/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 3:19 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and Vinod Kone.
> 
> 
> Bugs: MESOS-5822
>     https://issues.apache.org/jira/browse/MESOS-5822
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds a script that will be run on the ASF CI, similar to how the
> `docker_build.sh` script is used for the existing Linux-based CI.
> 
> This Jenkins job for Mesos on Windows can be found here:
> https://builds.apache.org/job/Mesos-Windows/
> 
> 
> Diffs
> -----
> 
>   support/windows-build.bat PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49926/diff/
> 
> 
> Testing
> -------
> 
> Pointed the Jenkins job at my local branch and triggered the build.
> 
> This is what Jenkins is running:
> ```
> :: Run a script provided by Visual Studio which sets up a
> :: couple environment variables needed by the build.
> CALL "F:/Microsoft/Visual Studio CE 2015/VC/vcvarsall.bat"
> 
> @echo on
> 
> :: TODO(josephw): Remove this once MESOS-5756 is resolved.
> :: Remove any previously generated protobuf directories.
> :: This forces CMake to regenerate the protobufs.
> RMDIR /q /s "build/include"
> RMDIR /q /s "build/src"
> 
> :: Recreate the `/tmp` directory needed by tests.
> RMDIR /q /s %CD:~0,3%tmp
> MKDIR %CD:~0,3%tmp
> if %errorlevel% neq 0 exit /b %errorlevel%
> 
> :: We need to specify the path to GNU Patch,
> :: since it is installed in a non-default location.
> SET OTHER_CMAKE_OPTIONS=-DPATCHEXE_PATH="F:/Program Files (x86)/GnuWin32/bin"
> 
> :: Call the Windows build script.
> "support/windows-build.bat"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message