mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 48593: Refactor Ranges Subtraction.
Date Mon, 11 Jul 2016 23:37:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48593/#review141789
-----------------------------------------------------------


Ship it!




Content-wise, looks good.  

I've left some comments below on a few stylistic nits, which I'll fix before committing.
I also went ahead and tweaked your patch description to explain what the improvement was.


src/common/values.cpp (lines 275 - 276)
<https://reviews.apache.org/r/48593/#comment207171>

    * Missing a space after `foreach`.
    * Missing curly braces.
    * Indent by 2 spaces, not 4.



src/common/values.cpp (lines 288 - 292)
<https://reviews.apache.org/r/48593/#comment207173>

    * Opening curly brace here stays inline.
    * Rename `s` variable to `interval`.
    * Indent with 2 spaces, not 3 :)



src/common/values.cpp (lines 395 - 397)
<https://reviews.apache.org/r/48593/#comment207176>

    Rename to `_left`, `_right`, `left`, and `right`.



src/common/values.cpp (line 401)
<https://reviews.apache.org/r/48593/#comment207178>

    Missing some spaces here.



src/tests/values_tests.cpp (line 318)
<https://reviews.apache.org/r/48593/#comment207180>

    Capitalize test name.  Here and below.



src/tests/values_tests.cpp (lines 338 - 339)
<https://reviews.apache.org/r/48593/#comment207181>

    This fits on one line.



src/tests/values_tests.cpp (line 366)
<https://reviews.apache.org/r/48593/#comment207183>

    Typo here: `tp`.



src/tests/values_tests.cpp (lines 369 - 370)
<https://reviews.apache.org/r/48593/#comment207182>

    Fits on one line.


- Joseph Wu


On July 11, 2016, 12:52 a.m., Yanyan Hu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48593/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 12:52 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Guangya Liu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5425
>     https://issues.apache.org/jira/browse/MESOS-5425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch reimplement Ranges subtraction using
> IntervalSet data type: Ranges values will be
> converted to IntervalSet values for subtraction
> and the result will be converted back to Ranges
> after subtraction is done. This change is for
> fixing jira MESOS-5425.
> 
> 
> Diffs
> -----
> 
>   src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b 
>   src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 
> 
> Diff: https://reviews.apache.org/r/48593/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yanyan Hu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message