mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49840: Fixed the right angle brackets in routing tests.
Date Mon, 11 Jul 2016 23:17:52 GMT


> On July 11, 2016, 10:15 p.m., Qian Zhang wrote:
> > Is this (">>") the coding convention of Mesos? If so, we may need to mention
it in https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md. And I see there
are still a lot of code in Mesos using "> >" now, maybe we need a separate patch to
update all of them?
> 
> Benjamin Bannier wrote:
>     The `> >` form is the exception to how C++ is used nowadays; that form works
around a deficiency where these right angle brackets might have been understood as some form
of `operator>>`. In C++11 which is used in Mesos we do not need this workaround. We
usually fix these as we touch code, but I filed MESOS-5830 for the sweep.

Got it, thanks Ben!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49840/#review141689
-----------------------------------------------------------


On July 9, 2016, 7:57 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49840/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 7:57 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the right angle brackets in routing tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/routing_tests.cpp 452a56da84f7508709d6e71f121bcf6219f992e6

> 
> Diff: https://reviews.apache.org/r/49840/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message