mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49841: Reorganized the routing tests into basic and advanced groups.
Date Mon, 11 Jul 2016 17:04:58 GMT


> On July 11, 2016, 2:46 p.m., Qian Zhang wrote:
> > So even we reorganize the routing tests into basic and advanced groups, all these
tests are still in the same file (routing_tests.cpp which is currently guarded by `WITH_NETWORK_ISOLATOR`
in Makefile.am) which means they will be compiled as a whole. So what if user just wants to
run basic tests but not the advanded tests? In this case, they also need the newer version
of libnl? Maybe we should reorganize them into two separate files, e.g., routing_tests.cpp
and advanced_routing_tests.cpp, the former can work with older version of libnl, and the later
has to work with newer version of libnl.

I can use #ifdef blocks to solve that for now.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49841/#review141691
-----------------------------------------------------------


On July 8, 2016, 11:57 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49841/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Advanced tests need some higher version of libnl.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/routing_tests.cpp 452a56da84f7508709d6e71f121bcf6219f992e6

> 
> Diff: https://reviews.apache.org/r/49841/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message