mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49839: Removed the network isolator specific check in netlink socket method.
Date Mon, 11 Jul 2016 14:10:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49839/#review141688
-----------------------------------------------------------


Ship it!




So the main purposal of this patch is to remove the dependency (e.g., `nl_has_capability()`)
of higher version of libnl from `routing::socket()` which can then work with lower version
of libnl, right?

- Qian Zhang


On July 9, 2016, 7:57 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49839/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 7:57 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This check has been performed in the port mapping isolator as well in
> the corresponding tests.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/internal.hpp 939634637d13497e77f4a8c3d4257eb98c92fa3f 
> 
> Diff: https://reviews.apache.org/r/49839/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message