mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.
Date Sun, 10 Jul 2016 14:11:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49820/#review141615
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 414 - 416)
<https://reviews.apache.org/r/49820/#comment206961>

    Why not make this consistent with the above ERROR LOG message?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 428)
<https://reviews.apache.org/r/49820/#comment206962>

    I do not think we need to call `_isolate()`, instead the following should be enough:
    ```
      return collect(isolates).then([]() { return Nothing(); });
    ```



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 433 - 442)
<https://reviews.apache.org/r/49820/#comment206963>

    I do not think we need this method.


- Qian Zhang


On July 9, 2016, 6:16 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49820/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 6:16 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CgroupsIsolatorProcess::isolate`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49820/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message