mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49815: Implemented `CgroupsIsolatorProcess::prepareHierarchy`.
Date Sun, 10 Jul 2016 12:53:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49815/#review141612
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 112 - 113)
<https://reviews.apache.org/r/49815/#comment206951>

    s/used/use/



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 114)
<https://reviews.apache.org/r/49815/#comment206952>

    s/different/be different/



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 119)
<https://reviews.apache.org/r/49815/#comment206950>

    I do not think we should name local variable starting with understore (like `_subsystemName`),
instead usually parameters of method can be named starting with understore. So I would suggest
to name the parameter `_subsystemName` and name local variable `subsystemName`.


- Qian Zhang


On July 9, 2016, 6:16 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49815/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 6:16 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CgroupsIsolatorProcess::prepareHierarchy`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49815/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message