mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 40054: Fix fetch parsing problem for URL with query.
Date Sun, 10 Jul 2016 00:35:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/#review141501
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Nov. 8, 2015, 3:57 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40054/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Benjamin Mahler.
> 
> 
> Bugs: MESOS-3367
>     https://issues.apache.org/jira/browse/MESOS-3367
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix fetch parsing problem for URL with query.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 
>   src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 
> 
> Diff: https://reviews.apache.org/r/40054/diff/
> 
> 
> Testing
> -------
> 
> # Add `FetcherTest.OSNetUriWithQueryTest` test case.
> # @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing
function for URL maybe better, it also could fix the TODO item. I think we also could update
the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename
function.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message