mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 29720: Bug fix: Added an executor container launch timeout timer
Date Sun, 10 Jul 2016 00:21:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29720/#review141477
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Jan. 12, 2015, 7:05 a.m., Nishant Suneja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29720/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 7:05 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-999
>     https://issues.apache.org/jira/browse/MESOS-999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A new executor launch timeout timer has been added. This timer gates the time in which
a successful executor container launch should happen. The executor registration timer starts
after the successful container launch.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 
>   src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6 
>   src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 
>   src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 
>   src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d 
>   src/tests/slave_tests.cpp a85a0282947278ce6e02e38093f8b88af4cb612a 
> 
> Diff: https://reviews.apache.org/r/29720/diff/
> 
> 
> Testing
> -------
> 
> make check succeeds.
> Added the unit test : SlaveTest:: ExecutorLaunchTimeoutTrigger.
> Added the unit test : SlaveTest:: ExecutorDelayedLaunchTimeoutTrigger.
> 
> 
> Thanks,
> 
> Nishant Suneja
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message