mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 29718: Bug fix: Start the executor registration timer, only when the container has launched successfully
Date Sat, 09 Jul 2016 23:27:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29718/#review141442
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Jan. 10, 2015, 4:19 p.m., Nishant Suneja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29718/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2015, 4:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-999
>     https://issues.apache.org/jira/browse/MESOS-999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As part of this bug fix, I have trigerred the executor registration timeout timer after
the container's future object is set, instead of starting the timer when the container launch
is still pending.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d 
>   src/tests/composing_containerizer_tests.cpp 5ab5a36cadb7f8622bad0c5814e9a5fb338753ad

>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/slave_tests.cpp a85a0282947278ce6e02e38093f8b88af4cb612a 
> 
> Diff: https://reviews.apache.org/r/29718/diff/
> 
> 
> Testing
> -------
> 
> make check succeeds.
> Added the unit test : SlaveTest::SuccessfulExecutorRegistrationTimeoutTrigger
> Added the unit test :  SlaveTest::FailedExecutorRegistrationTimeoutTrigger
> 
> 
> Thanks,
> 
> Nishant Suneja
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message