mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 28189: Do not allocate additional resources for CommandExecutor.
Date Sat, 09 Jul 2016 23:25:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28189/#review141438
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Nov. 18, 2014, 10:54 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28189/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 10:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1718
>     https://issues.apache.org/jira/browse/MESOS-1718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use the first task's resources if the ExecutorInfo does not specify any resources. This
avoids the previous slight overcommit.
> 
> I decided to make this review to just removing the overcommit. We'll need to deprecate
the behavior of accepting executors without resources and we should do the transfer from task
to executor for command executors then. Note, as Ben pointed on the other review, this transfer
cannot be done at the slave level because command executors are not re-registered with the
master and we need to send the true task resources.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f 
> 
> Diff: https://reviews.apache.org/r/28189/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message