mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 25945: Pass Promise to DispatchEvent to correctly fail on rejection.
Date Sat, 09 Jul 2016 23:22:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/#review141432
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
for reopening reviews.

- Joris Van Remoortere


On Oct. 14, 2014, 8:09 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25945/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 8:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Benjamin Mahler.
> 
> 
> Bugs: MESOS-1456, MESOS-1751 and MESOS-1866
>     https://issues.apache.org/jira/browse/MESOS-1456
>     https://issues.apache.org/jira/browse/MESOS-1751
>     https://issues.apache.org/jira/browse/MESOS-1866
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Create a PromiseDispatchEvent to allow failing of promises if the DispatchEvent can't
be enqueued.
> 
> Also converted some shared_ptr to Owned to correctly track ownership.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da2828cf36b6143d627dac66f3e0cc4416bae4

>   3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976

>   3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9

>   3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227

>   3rdparty/libprocess/include/process/event.hpp bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8

>   3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b

>   3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
>   3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b

>   src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd 
> 
> Diff: https://reviews.apache.org/r/25945/diff/
> 
> 
> Testing
> -------
> 
> Added test that fails without the patch.
> 
> Ran all tests (make check) with g++-4.4 and clang-3.5.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message